New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throws an exception with ng-repeat and filter #30

Closed

denisgursky opened this issue May 9, 2014 · 5 comments

denisgursky commented May 9, 2014

Hi,

I'm trying to use it with ng-repeat and filter and it works well, but it thorws an exception when an item is filtered. Here's plunker http://plnkr.co/edit/BCncXn8Y2BWOcREPyGLm?p=preview

Exception:

TypeError: Cannot read property '$id' of undefined
at getContextForScope (http://run.plnkr.co/DLrCmya3BDW2kbOQ/angular-scroll.js:246:25)
at getContextForSpy (http://run.plnkr.co/DLrCmya3BDW2kbOQ/angular-scroll.js:255:14)
at Object.removeSpy (http://run.plnkr.co/DLrCmya3BDW2kbOQ/angular-scroll.js:266:21)
at http://run.plnkr.co/DLrCmya3BDW2kbOQ/angular-scroll.js:436:20
at Scope.$broadcast (https://code.angularjs.org/1.3.0-beta.5/angular.js:12697:28)
at Scope.$destroy (https://code.angularjs.org/1.3.0-beta.5/angular.js:12355:14)
at ngRepeatAction (https://code.angularjs.org/1.3.0-beta.5/angular.js:20609:27)
at Object.$watchCollectionAction as fn
at Scope.$digest (https://code.angularjs.org/1.3.0-beta.5/angular.js:12257:29)
at Scope.$apply (https://code.angularjs.org/1.3.0-beta.5/angular.js:12522:24) angular.js:9784
Event tracked Plunk Save Toolbar undefined undefined

oblador closed this as completed in

8dd2497

Owner

oblador commented May 9, 2014

Thanks for the report and plunker! Now fixed, do you need a new release?

Author

denisgursky commented May 9, 2014

Thanks for fast fixing! No, I don't.

hswolff commented May 12, 2014

I'd love a new release if you'd be so kind!

Owner

oblador commented May 12, 2014

@hswolff Here you go!

hswolff commented May 12, 2014

You're my favorite. <3!!!!

🎆 🎆 🎆 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment