Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail when switching screen sizes #48

Closed
stefvhuynh opened this issue Dec 21, 2017 · 4 comments
Closed

Tests fail when switching screen sizes #48

stefvhuynh opened this issue Dec 21, 2017 · 4 comments

Comments

@stefvhuynh
Copy link

stefvhuynh commented Dec 21, 2017

When I run loki update on my computer monitor, I get updated reference images and my tests pass. When I unplug from my monitor and run loki test on my laptop, the tests fail. My monitor is larger than my computer. Any ideas about why this might be?

@stefvhuynh stefvhuynh changed the title Tests fail when switching between different screen sizes Tests fail when switching screen sizes Dec 21, 2017
@oblador
Copy link
Owner

oblador commented Dec 23, 2017

Are you using docker or regular app? Do you have different pixel densities on your laptop vs monitor?

@stefvhuynh
Copy link
Author

using regular app. i do believe have different pixel densities. this becomes more of a problem when doing CI. i have no idea what settings to use for those machines.

@boygirl
Copy link
Contributor

boygirl commented Jan 18, 2018

@oblador Do you have any recommendations for making loki run reliably in CI without using docker? Is it possible, or do we need to set up docker to make this work?

@oblador
Copy link
Owner

oblador commented Jun 17, 2018

Closing this as a wontfix. IMHO, the only use case for using local chrome app is when you're a sole dev and don't use CI. Keeping environments between multiple machines identical is super hard without some kind of container.

@oblador oblador closed this as completed Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants