Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDI 4.9.95: Issue Accessing F0000+ Address Range Icons #1136

Open
2 tasks done
MutableLoss opened this issue Feb 21, 2020 · 2 comments
Open
2 tasks done

MDI 4.9.95: Issue Accessing F0000+ Address Range Icons #1136

MutableLoss opened this issue Feb 21, 2020 · 2 comments

Comments

@MutableLoss
Copy link

Environment

OSX 10.15/Xcode 11
Testing on iOS 13.3

Description

I have been attempting to use the ideogram icons, and have been attempting to manually upgrade the MaterialCommunityIcons to version 4.9.95 to gain access to the new fonts. While it works to an extent, any icon accessed that is placed above the SSP set address (F0000+), shows a character outside the MDI set. After some testing out a few different addresses, this range seems to be accessing the System and CJK Fonts (shapes, Chinese, Japanese, Korean characters). All other icons mapped with lesser values, work without issue.

A few examples of fonts showing this behavior:

'ideogram-cjk': F035C
'ideogram-cjk-variant': F035D
'coffee-to-go-outline': F0339
'file-multiple-outline': F0054

I tried two completely different methods to make sure it wasn't a font set issue:

  • Update glyphmap in package, then re-generate MaterialCommunityIcons with the materialcommunityicon.sh script found on master.
  • remove all references to vector-icons linked MaterialCommunityIcons font file, manually link the 4.9.95 font file, and create a custom font set using the createIconSet method. I was able to verify the use of this file, due to the native placement and size.

Both scenarios yielded the same results. Can anyone explain what the cause of this conflict is?

Demo

ideogram-cjk:
cjk

file-multiple-outline:
file-outline

@giannismacheras
Copy link
Contributor

This has happened to me as well with coin-outline and dice-multiple-outline.

@dimbslmh
Copy link

dimbslmh commented May 3, 2020

Breaking Changes in MDI v5.0.45 Templarian/MaterialDesign#4901

Codepoint Remapping

The codepoints in all font files are being remapped to move our icons into a Private Use Area of Unicode, starting at F0001

@oblador Starting from MDI v5.0.45, all mdi icons won't work with String.fromCharCode.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/fromCharCode

The static String.fromCharCode() method returns a string created from the specified sequence of UTF-16 code units.

The range is between 0 and 65535 (0xFFFF). Numbers greater than 0xFFFF are truncated. No validity checks are performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants