Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade darling & syn #662

Closed
obmarg opened this issue May 7, 2023 · 4 comments
Closed

Upgrade darling & syn #662

obmarg opened this issue May 7, 2023 · 4 comments
Labels
🧹 chore
Milestone
3.next

Comments

@obmarg
Copy link
Owner

obmarg commented May 7, 2023

syn 2 has been released, as has darling 0.20 which supports it. Should probably get these upgrades in prior to releasing 3.0
@obmarg obmarg added this to the 3.0.0 milestone May 7, 2023
@obmarg
Copy link
Owner Author

obmarg commented May 8, 2023 •
edited

I might hold off on this until all the other deps in cynic have updated to syn 2.0. These crates in the dep tree seem to be using syn:

  • serde (an upgrade is available for this)
  • darling (can be upgraded)
  • ouroboros (PR here)
  • rstest (upgraded but not released - though this is a dev dep so maybe fine to skip)
  • thiserror (upgraded)

@obmarg obmarg removed this from the 3.0.0 milestone May 8, 2023
@obmarg
Copy link
Owner Author

obmarg commented Jun 22, 2023

All of these are released so i should probably do them

@obmarg obmarg added this to the 3.next milestone Jun 22, 2023
@obmarg
Copy link
Owner Author

obmarg commented Sep 17, 2023 •
edited

This is mostly handled in #780 - rkyv still pulls in syn 1 though unfortunately.

@obmarg
Copy link
Owner Author

obmarg commented Sep 18, 2023

Going to consider this done for now.

@obmarg obmarg closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧹 chore
Projects
None yet
Milestone
3.next
Development

No branches or pull requests
1 participant
@obmarg