Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dip in CL equivalent class axioms detected #2075

Closed
matentzn opened this issue Sep 30, 2021 · 4 comments
Closed

Dip in CL equivalent class axioms detected #2075

matentzn opened this issue Sep 30, 2021 · 4 comments

Comments

@matentzn
Copy link
Contributor

I can see things like this in the diff:

image

I chased this down to this goal:

$(TMPDIR)/cl-core.obo: $(SRC)
	owltools $(URIBASE)/cl.owl  --make-subset-by-properties -n BFO:0000050 BFO:0000051 RO:0002202 RO:0002215 --remove-external-classes -k CL --remove-dangling --remove-axiom-annotations --remove-imports-declarations -o -f obo --no-check $@

The cl.owl that goes in still has the correct axioms ($(URIBASE)/cl.owl), $(TMPDIR)/cl-core.obo does not. No idea why this never showed up before. It should have! --remove-external-classes -k CL is probably the reason, so in my opinion this closing this is acceptable, but I want to mention it to @dosumis and @cmungall as an FYI.

@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically in one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Mar 31, 2022
@paolaroncaglia
Copy link
Contributor

@matentzn @shawntanzk @dosumis
Tagging you as author and assignees respectively
Can this be closed? If not, I already added it to the tech board. Thanks.

@shawntanzk
Copy link
Collaborator

@paolaroncaglia will make sure it gets looked at next meeting

@shawntanzk shawntanzk added tech and removed Stale labels Mar 31, 2022
@shawntanzk
Copy link
Collaborator

Closing this - will also solve itself once we move to base module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

4 participants