Skip to content

Commit

Permalink
Add ArgoCD 1.8.x to acceptance testing matrix (#43)
Browse files Browse the repository at this point in the history
* test against argocd 1.8.x
* build and test against Go 1.15, update local development testing ArgoCD version to 1.8.2
* updated README about container images side-loading and OS limits during local development
* chore: removed useless workarounds intended for argocd 1.5.x
  • Loading branch information
oboukili committed Jan 17, 2021
2 parents 2d88e14 + bbf6e11 commit f703e45
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 2,626 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.14
go-version: 1.15

- name: Import GPG key
id: import_gpg
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Expand Up @@ -14,12 +14,12 @@ jobs:
strategy:
fail-fast: false
matrix:
argocd_version: ["v1.7.8", "v1.6.2", "v1.5.8"]
argocd_version: ["v.1.8.2", "v1.7.11", "v1.6.2"]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v1
with:
go-version: 1.14
go-version: 1.15
id: go
- name: Restore Go cache
uses: actions/cache@v1
Expand Down
13 changes: 13 additions & 0 deletions README.md
Expand Up @@ -319,6 +319,19 @@ make testacc
make testacc_clean_env
```

**Note:** to speed up testing environment setup, it is highly recommended you pull all needed container images into your local registry first, as the setup tries to sideload the images within the Kind cluster upon cluster creation.

For example if you use Docker as your local container runtime:
```shell
docker pull argoproj/argocd:v1.8.2
docker pull ghcr.io/dexidp/dex:v2.27.0
docker pull redis:5.0.10-alpine
```

#### Troubleshooting during local development

* **"too many open files":** Running all acceptance tests in parallel (the default) may open a lot of files and sockets, therefore ensure your local workstation [open files/sockets limits are tuned accordingly](https://k6.io/docs/misc/fine-tuning-os).

---

## Credits
Expand Down

0 comments on commit f703e45

Please sign in to comment.