fix: constant orphaned changes if not specified & crash

[MrLuje]

Resolves #105 & #104

To be on par with the API surface of Argo CD, "orphaned resources monitoring" will be only enabled if it is explicitly declared. Monitoring enabled because of the previous default behavior will be detected as a removal on next apply.

This is a BREAKING CHANGE with the current version :

"Orphaned resources" block specified	Current version	This PR
Yes	Enables monitoring	Enables monitoring
No	Enables monitoring	Disables monitoring

[oboukili]

Good catch!

[MrLuje]

I took a look at the failing test TestAccArgoCDProject_tokensCoexistence which has ExpectNonEmptyPlan: true. I suppose the non-empty plan was due to the orphaned_resources bug and not the behavior being tested.

Here is the plan generated on master :

/terraform-provider-argocd/argocd/resource_argocd_project_test.go:72: Step 1/1, expected an error with pattern, no match on: After applying this test step, the plan was not empty.
        stdout:


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # argocd_project.coexistence will be updated in-place
          ~ resource "argocd_project" "coexistence" {
                id = "test-acc-zozru04kea"

              ~ metadata {
                  + annotations      = {}
                  + labels           = {}
                    name             = "test-acc-zozru04kea"
                    # (4 unchanged attributes hidden)
                }

              ~ spec {
                  + signature_keys = []
                    # (2 unchanged attributes hidden)


                  - orphaned_resources {
                    }

                  ~ role {
                      + groups   = []
                        name     = "testrole"
                        # (1 unchanged attribute hidden)
                    }
                    # (1 unchanged block hidden)
                }
            }

        Plan: 0 to add, 1 to change, 0 to destroy.

If this is ok with you, I'll remove the ExpectNonEmptyPlan from this test

[oboukili]

Hi, ah yes good catch again! Please go ahead!