Add post-entrypoint to unlock the app on cancellation #7
Conversation
| echo "Unlocking Dokku deployment"; | ||
|
|
||
| app=$(echo $DOKKU_REPO | sed -e 's/.*\///') | ||
| ssh -p ${ssh_port:=22} dokku@$ssh_host apps:unlock $app |
There was a problem hiding this comment.
apps:unlock requires dokku >= 0.11.6, you should maybe write that somewhere in the readme?
There was a problem hiding this comment.
Also, this assumes that the dokku user on remote in actually called dokku.
I don't know if it could ever be changed.
Probably not, since the official dokku_client.sh assumes that the user is dokku as well: https://github.com/dokku/dokku/blob/master/contrib/dokku_client.sh#L149.
So it's probably fine.
There was a problem hiding this comment.
apps:unlockrequires dokku >= 0.11.6, you should maybe write that somewhere in the readme?
Good idea !
| echo "Unlocking Dokku deployment"; | ||
|
|
||
| app=$(echo $DOKKU_REPO | sed -e 's/.*\///') | ||
| ssh -p ${ssh_port:=22} dokku@$ssh_host apps:unlock $app |
There was a problem hiding this comment.
Also, this assumes that the dokku user on remote in actually called dokku.
I don't know if it could ever be changed.
Probably not, since the official dokku_client.sh assumes that the user is dokku as well: https://github.com/dokku/dokku/blob/master/contrib/dokku_client.sh#L149.
So it's probably fine.
Version 1.0.3 does not exist which breaks the action
No description provided.