Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pngjs fails to read BC vaccine card QR codes #7

Closed
christopher0936 opened this issue Sep 9, 2021 · 5 comments
Closed

pngjs fails to read BC vaccine card QR codes #7

christopher0936 opened this issue Sep 9, 2021 · 5 comments

Comments

@christopher0936
Copy link

Isolated issue to the call to the PNG library to that defines imageData.

PNG fails to read the image and throws error "unrecognised content at end of stream"

@kjalen
Copy link

kjalen commented Sep 9, 2021

If you crop the image down to just the QR code it should work. But I agree it would be nice if it worked with the whole image.

@obrassard
Copy link
Owner

👋 Hello, I don't think I'll have time to work on it for a while, so if any of you want to try to improve this, I encourage you to do it!

@kjalen
Copy link

kjalen commented Sep 9, 2021

Isolated issue to the call to the PNG library to that defines imageData.

PNG fails to read the image and throws error "unrecognised content at end of stream"

Did some testing, this is actually what happens when you upload something other than a png. Convert your image to png and it should work fine.

@obrassard
Copy link
Owner

obrassard commented Sep 10, 2021

@kjalen PR's #8 Improved the error message related to this issue.
But I will keep it open in case someone wants to improve the QR code identification in the more complex images and/or to add support for other image types

@obrassard
Copy link
Owner

Closing this since #6 add support for BC qr codes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants