Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading swagger & chopper client #27

Closed
obrunsmann opened this issue Mar 31, 2022 · 1 comment
Closed

Upgrading swagger & chopper client #27

obrunsmann opened this issue Mar 31, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@obrunsmann
Copy link
Contributor

There is a new swagger file available for nakama's REST API: https://github.com/heroiclabs/nakama/blob/master/apigrpc/apigrpc.swagger.json

Problem:
There some chopper updates which are currently making it impossible to just generate a new client. For some reason all new generated methods getting prefixed with the path which should be a chopper config.

Bildschirmfoto 2022-03-31 um 14 23 58

When I started working on this project I heavily thought about using chopper or writing REST models by hand. Supporting REST + gRPC in parallel for this package is some kind of a challenge. Now unfortunately there is the downside of this approach, that needs a fix for the chopper config.

I think I would be able to check this on weekend, but cannot promise within just a few hours here.
@obrunsmann obrunsmann added the good first issue Good for newcomers label Mar 31, 2022
@obrunsmann obrunsmann mentioned this issue Mar 31, 2022
Closed
obrunsmann added a commit that referenced this issue Aug 11, 2022
@obrunsmann
Squashed commit of the following:
e3736fc 
Fixed #27

commit ee25ba4131493e4f3d4943ac868637a1b2d5cd93
Author: Oliver Brunsmann <oliver@brunsmann.io>
Date:   Thu Aug 11 22:12:05 2022 +0200

    Upgrades packages and rest client

commit dea090e87de72cd33c7868f8111a8af368d4f261
Author: Oliver Brunsmann <oliver@brunsmann.io>
Date:   Thu Aug 11 10:40:18 2022 +0200

    Updates swagger file

commit 0790ed495df2d40737b16f5f61a906f5abd4ff6a
Author: Oliver Brunsmann <oliver@brunsmann.io>
Date:   Thu Aug 11 10:40:03 2022 +0200

    Upgrades packages
@obrunsmann
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@obrunsmann