Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Packages.app #453

Merged
merged 1 commit into from Sep 29, 2023
Merged

Remove the Packages.app #453

merged 1 commit into from Sep 29, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Sep 29, 2023

We no longer use the Packages.app to create pkg on Mac.
The hash of Packages.app is changed and it causes the build failure so that I want to remove the Packages.app.

Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umireon this is being used though in our build scripts, i believe, no?

@umireon
Copy link
Member Author

umireon commented Sep 29, 2023

Packages.app is not used on our build script actually. I replaced the usage of the Packages.app with the commands that is included in Xcode such as pkgbuild and productbuild.

Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - Go!

@umireon umireon merged commit 4d2dd37 into main Sep 29, 2023
6 checks passed
@umireon umireon deleted the umireon.remove-packages-app branch September 29, 2023 23:07
@umireon umireon restored the umireon.remove-packages-app branch October 1, 2023 16:14
@umireon umireon added this to the 1.1.7 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants