Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle model load bug #458

Merged
merged 3 commits into from Oct 4, 2023
Merged

Handle model load bug #458

merged 3 commits into from Oct 4, 2023

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Oct 4, 2023

While this is not a formal fix for the bug, it adds robustness and better logging

@royshil royshil requested a review from umireon October 4, 2023 12:31
@royshil royshil self-assigned this Oct 4, 2023
@royshil royshil mentioned this pull request Oct 4, 2023
Closed
umireon
umireon approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royshil royshil merged commit f965cf2 into main Oct 4, 2023
6 checks passed
@royshil royshil deleted the roy.fix_model_load_bug_and_garnish branch October 4, 2023 16:27
@umireon umireon added this to the 1.1.7 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umireon umireon umireon approved these changes

Assignees

@royshil royshil

Labels
None yet
Projects
None yet
Milestone
1.1.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@royshil @umireon