Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updater crash #469

Merged
merged 6 commits into from Oct 10, 2023
Merged

Fix updater crash #469

merged 6 commits into from Oct 10, 2023

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Oct 9, 2023

No description provided.

@royshil royshil requested a review from umireon October 9, 2023 01:54
@royshil royshil self-assigned this Oct 9, 2023
@royshil royshil mentioned this pull request Oct 9, 2023
Closed
@royshil royshil added this to the 1.1.7 milestone Oct 9, 2023
@royshil
Copy link
Collaborator Author

royshil commented Oct 10, 2023

@umireon are you able to review this? the folks in #454 have confirmed it resolves their bug

umireon
umireon approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royshil royshil merged commit 0ac64a8 into main Oct 10, 2023
12 checks passed
@royshil royshil deleted the roy.fix_updater_crash branch October 10, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umireon umireon umireon approved these changes

Assignees

@royshil royshil

Labels
Seeking Testers
Projects
None yet
Milestone
1.1.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@royshil @umireon