Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline expressions shouldn’t use a wrapper span #11

Closed
mbostock opened this issue Oct 17, 2023 · 0 comments · Fixed by #1416 or #1439
Closed

Inline expressions shouldn’t use a wrapper span #11

mbostock opened this issue Oct 17, 2023 · 0 comments · Fixed by #1416 or #1439
Assignees
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

In a case like this…

<div class="grid grid-cols-4" style="grid-auto-rows: 86px;">
  ${modes.map(mode => BigNumber(events[0][mode], {title: mode}))}
</div>

we really want to avoid the wrapper SPAN element so that each interpolated big number is a direct descending of the grid container. Maybe we can do this using document fragments? And comment nodes to denote where the fragment starts and ends?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant