Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the dev server crashes when we remove or rename a file #36

Closed
Fil opened this issue Oct 20, 2023 · 1 comment
Closed

the dev server crashes when we remove or rename a file #36

Fil opened this issue Oct 20, 2023 · 1 comment

Comments

@Fil
Copy link
Contributor

Fil commented Oct 20, 2023

to reproduce:

cd cli/
yarn dev

open http://127.0.0.1:3000/markdown

mv docs/markdown.md ./

navigate to http://127.0.0.1:3000/javascript by clicking on "JavaScript reference" in the side bar

↑ {
  type: 'hello',
  path: '/markdown',
  hash: '13f37e067d6239136c9165ffd158da4161de47b99b8c55d7441d387ffd4b1e04'
}
node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Error: ENOENT: no such file or directory, open 'docs/markdown.md'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'docs/markdown.md'
}

@wiltsecarpenter wiltsecarpenter self-assigned this Oct 20, 2023
@wiltsecarpenter
Copy link
Contributor

This is now fixed in main, but I was unsure what to do when a markdown file is deleted or renamed. For now, it just ignores that event, which means the client will stop receiving updates, but will continue to show whatever it last had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants