Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect broken socket and reconnect automatically #50

Closed
mbostock opened this issue Oct 23, 2023 · 4 comments · Fixed by #1127
Closed

Detect broken socket and reconnect automatically #50

mbostock opened this issue Oct 23, 2023 · 4 comments · Fixed by #1127
Assignees
@mbostock
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

If the socket closes, the client never tries to reopen and reconnect.
@mbostock mbostock added the bug Something isn’t working label Oct 23, 2023
@mbostock
Copy link
Member Author

We could also do a version check and reload the page (avoiding the client running stale code during development).

@mbostock mbostock added this to the Early access milestone Nov 13, 2023
@cinxmo cinxmo self-assigned this Nov 15, 2023
@mbostock mbostock mentioned this issue Feb 1, 2024
Closed
@mbostock mbostock modified the milestones: General availability, Future Feb 13, 2024
@code-SL
Copy link

code-SL commented Feb 16, 2024

Note that in neovim, set backupcopy=yes needs to be set or else socket is closed upon save. Emacs doesn't seem to exhibit the same problematic default setting that closes upon save.

@Fil
Copy link
Contributor

Fil commented Feb 16, 2024

related #563

@eitanlees
Copy link

Thank you @code-SL for the neovim solution!

I added the following to ~/.config/nvim/init.lua

vim.opt.backupcopy = 'yes'

and that alleviated the issue.

@mbostock mbostock mentioned this issue Mar 22, 2024
Merged
@mbostock mbostock self-assigned this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

automatic reconnect observablehq/framework
5 participants
@Fil @mbostock @eitanlees @code-SL @cinxmo