Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked assets should auto-refresh on edit #908

Closed
mbostock opened this issue Feb 24, 2024 · 4 comments
Closed

Linked assets should auto-refresh on edit #908

mbostock opened this issue Feb 24, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

A generalization of #415. For example if you have an <img> tag, we detect this a linked file; we could generate a URL with a hash, and push down the changes over the socket if the file changes.

@trebor
Copy link
Contributor

trebor commented Feb 24, 2024

#905 explicitly covers stylesheets and images. other types i can think off the top of my head are:

  • fonts
  • audio
  • video
  • scripts with the script tag
  • iframe for local html files

i can image fully general code that looks for href or src fields starting with the asset file name - rather than handling them one by one.

@mbostock
Copy link
Member Author

This may end up colliding with #843 which affects nearly everything involving files and imports.

@trebor
Copy link
Contributor

trebor commented Feb 25, 2024

got it, maybe hold of until #843 lands.

@mbostock
Copy link
Member Author

mbostock commented Mar 1, 2024

Fixed in #843.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants