Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose flag traces.read.endpoint in jsonnet #267

Closed
pavolloffay opened this issue Mar 30, 2022 · 2 comments · Fixed by #271
Closed

Expose flag traces.read.endpoint in jsonnet #267

pavolloffay opened this issue Mar 30, 2022 · 2 comments · Fixed by #271

Comments

@pavolloffay
Copy link
Member

Follow up #252 and similar to https://github.com/observatorium/api/pull/247/files#diff-d79e05fae1c17a80c15dfd8e05409c355f8eb20c179667763c26ef6351c18fbfR135

The flag --traces.read.endpoint needs to be exposed in jsonnet to accordingly configure API service.
@pavolloffay
Copy link
Member Author

@esnible would you like to take a look at this?

@pavolloffay
Copy link
Member Author

After the change is implemented the API jsonnet in https://github.com/observatorium/observatorium needs to be upgraded and k8s resources regenerated with the API read endpoint.

This was referenced Mar 30, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pseudo-tenancy for trace queries esnible/api-1
1 participant
@pavolloffay