Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate (some) scripts with GitHub Actions #153

Closed
11 tasks done
claremacrae opened this issue Dec 11, 2021 · 9 comments
Closed
11 tasks done

Automate (some) scripts with GitHub Actions #153

claremacrae opened this issue Dec 11, 2021 · 9 comments

Comments

@claremacrae
Copy link
Contributor

claremacrae commented Dec 11, 2021

Candidate tasks:

  • Updating theme download counts
  • Adding new theme, plugin and people pages
  • Generating the MOCs
  • Running the Python tests
  • Turn off progress display on the slower scripts - they make the logs hard to read
  • Make it create a PR
  • Decide which things happen only on main - and adjust the YAML to implement that
  • Or decide what will trigger the job that creates commits - maybe a nightly cron job?
    • update_hub will only run on manual trigger, and only on main branch
    • The other two will run on pushes and PRs
    • So the workflow for updating releases will be:
      • Trigger update_hub
      • 3 minutes later, review and accept PR
      • Pull the changes to your branch
      • Run update_releases.py with --overwrite
      • Review and push edits
    • Over time, we should be eventually able to add the --overwrite step to update_hub.yml
  • Finish addressing comments from code review
  • Remove push and pr triggers on update_hub

After Merge

Defer to later on

Probably add new issues for these, if they don't exist already

@claremacrae claremacrae created this issue from a note in Hub Tools & Scripts (To do) Dec 11, 2021
@claremacrae claremacrae moved this from To do to In progress in Hub Tools & Scripts Jan 4, 2022
@claremacrae claremacrae self-assigned this Jan 4, 2022
@claremacrae
Copy link
Contributor Author

The background to this is written up at:
03.03 Scripts and Automation GitHub Actions for the Hub

@claremacrae
Copy link
Contributor Author

I'm doing this on my fork of this repo for now - and the logs are available

@claremacrae
Copy link
Contributor Author

Progress: I've now got meaningful output from an intentionally failing test:

https://github.com/claremacrae/obsidian-hub/runs/4707955213?check_suite_focus=true#step:5:45

image

@claremacrae
Copy link
Contributor Author

Theme download counts now get updated automatically:

image

@claremacrae
Copy link
Contributor Author

@argenos This is the GitHub Action I'm using to create a PR...

There's a lot to think about its behaviour:
https://github.com/peter-evans/create-pull-request

@argenos argenos closed this as completed Jan 10, 2022
Hub Tools & Scripts automation moved this from In progress to Done Jan 10, 2022
@claremacrae
Copy link
Contributor Author

Reopening as there are a few more checklist items to do, in the description of this issue.

@argenos If not already done, when you have a mo, please could you adjust the branch protection to enable "checks must have passed on protected branch"?

@claremacrae claremacrae reopened this Jan 10, 2022
Hub Tools & Scripts automation moved this from Done to In progress Jan 10, 2022
@claremacrae
Copy link
Contributor Author

Oh yes, could you also cherry-pick the README Heading changes some time? Thanks!

@claremacrae
Copy link
Contributor Author

Oh yes, could you also cherry-pick the README Heading changes some time? Thanks!

Forgot to ping @argenos

@claremacrae
Copy link
Contributor Author

All the remaining actions here have been moved to separate issues, so this can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants