New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/reviewer add footer #319
Conversation
Add link to checklist for reviewers.
I just saw #318 (comment), so this PR is probably unnecessary. |
It might be a good idea to add a notice of the GitHub action where I added the reference to the I'll keep this PR open until I open an issue about it so that it's tracked. |
...e Obsidian Hub/03 Contributor Notes/03.01 Structure/Checklist for reviewing Pull Requests.md
Outdated
Show resolved
Hide resolved
...bute to the Obsidian Hub/03 Contributor Notes/03.03 Scripts and Automation/Adding footers.md
Show resolved
Hide resolved
Hahah - I keep working through the emails and then finding you are way ahead of me... :-) The new page here is definitely worth adding, though I suggested a possible minor addition to the wording.. I haven't figured out how to update the other existing pages on individual scripts to the addition of Github Actions... |
Yeah. It's all got quite complicated... It was so much easier to update it when it was in the Wiki, but I lost that vote... Perhaps we could pair on all these scripts at some point - as I've tried several times to update them, and got stuck every time, especially on the |
Add mention of update_hub action to "adding footers" note. Add explanation of what it includes to the "GitHub Actions for the Hub" note.
of individual scripts, because they are included in this action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant - thank you.
...e Obsidian Hub/03 Contributor Notes/03.03 Scripts and Automation/update_hub GitHub Action.md
Show resolved
Hide resolved
...e Obsidian Hub/03 Contributor Notes/03.03 Scripts and Automation/update_hub GitHub Action.md
Show resolved
Hide resolved
@kometenstaub Many thanks... if you are happy with my additions, please do go ahead and merge... |
@kometenstaub FYI when #307 is merged, the review checklist item about updating the directory tree will no longer be needed as it will be done as part of I'll delete that instruction in a minute - when I've finished merging that PR... |
This is now done in update_hub, thanks to #307
Done - also updated the docs for update_hub to note that it updates the directory tree... Over to you @kometenstaub ! |
Thank you for your review and the additions. :) |
Edited
Added
Checklist
.md
extension