Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/reviewer add footer #319

Merged
merged 8 commits into from Feb 27, 2022
Merged

Docs/reviewer add footer #319

merged 8 commits into from Feb 27, 2022

Conversation

kometenstaub
Copy link
Contributor

Edited

  • checklist for reviewers
  • scripting MOC

Added

  • "Adding footers" note

Checklist

@kometenstaub
Copy link
Contributor Author

I just saw #318 (comment), so this PR is probably unnecessary.

@kometenstaub
Copy link
Contributor Author

kometenstaub commented Feb 26, 2022

It might be a good idea to add a notice of the GitHub action where I added the reference to the add_footer script. It still has a reference to the MOC script, and I didn't check the update_hub action..

I'll keep this PR open until I open an issue about it so that it's tracked.

@kometenstaub kometenstaub mentioned this pull request Feb 26, 2022
4 tasks
@claremacrae
Copy link
Contributor

I just saw #318 (comment), so this PR is probably unnecessary.

Hahah - I keep working through the emails and then finding you are way ahead of me... :-)

The new page here is definitely worth adding, though I suggested a possible minor addition to the wording..

I haven't figured out how to update the other existing pages on individual scripts to the addition of Github Actions...

@claremacrae
Copy link
Contributor

It might be a good idea to add a notice of the GitHub action where I added the reference to the add_footer script. It still has a reference to the MOC script, and I didn't check the update_hub action..

I'll keep this PR open until I open an issue about it so that it's tracked.

Yeah. It's all got quite complicated... It was so much easier to update it when it was in the Wiki, but I lost that vote...

Perhaps we could pair on all these scripts at some point - as I've tried several times to update them, and got stuck every time, especially on the update_releases.py one.

Add mention of update_hub action to "adding footers" note. Add explanation of
what it includes to the "GitHub Actions for the Hub" note.
of individual scripts, because they are included in this action.
Copy link
Contributor

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant - thank you.

@claremacrae
Copy link
Contributor

@kometenstaub Many thanks... if you are happy with my additions, please do go ahead and merge...

@claremacrae
Copy link
Contributor

@kometenstaub FYI when #307 is merged, the review checklist item about updating the directory tree will no longer be needed as it will be done as part of update_hub...

I'll delete that instruction in a minute - when I've finished merging that PR...

@claremacrae
Copy link
Contributor

@kometenstaub FYI when #307 is merged, the review checklist item about updating the directory tree will no longer be needed as it will be done as part of update_hub...

I'll delete that instruction in a minute - when I've finished merging that PR...

Done - also updated the docs for update_hub to note that it updates the directory tree...

Over to you @kometenstaub !

@kometenstaub
Copy link
Contributor Author

Thank you for your review and the additions. :)

@kometenstaub kometenstaub merged commit b31a248 into main Feb 27, 2022
@kometenstaub kometenstaub deleted the docs/reviewer-add-footer branch February 27, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants