Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some images for recent themes are broken, #536

Closed
claremacrae opened this issue Nov 14, 2022 · 1 comment
Closed

Some images for recent themes are broken, #536

claremacrae opened this issue Nov 14, 2022 · 1 comment

Comments

@claremacrae
Copy link
Contributor

claremacrae commented Nov 14, 2022

In 02 - Community Expansions/02.05 All Community Expansions/Themes/Micro Mike.md - added in #534 - several new Themes have broken images.

The problem files are:

  • 02 - Community Expansions/02.05 All Community Expansions/Themes/Fusion.md
  • 02 - Community Expansions/02.05 All Community Expansions/Themes/Micro Mike.md
  • 02 - Community Expansions/02.05 All Community Expansions/Themes/SynthWave.md
  • 02 - Community Expansions/02.05 All Community Expansions/Themes/ion.md

It looks to me like the images are being read from master, but the correct branch is main.

This image does not exist:
https://github.com/ThisTheThe/MicroMike/raw/master/screenshotThumb.png

This one does:
https://github.com/ThisTheThe/MicroMike/raw/main/screenshotThumb.png

The same applies to several other pages in the same PR.

Originally posted by @claremacrae in #534 (comment)

@claremacrae
Copy link
Contributor Author

This has been fixed by two separate PRs:

As a spot-check:

The problem files are:

  • 02 - Community Expansions/02.05 All Community Expansions/Themes/Fusion.md

Now works

  • 02 - Community Expansions/02.05 All Community Expansions/Themes/Micro Mike.md

Now works

  • 02 - Community Expansions/02.05 All Community Expansions/Themes/SynthWave.md

Now works

  • 02 - Community Expansions/02.05 All Community Expansions/Themes/ion.md

Now works


Resolving as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant