Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle task done command should add the global task filter text #1320

Open
claremacrae opened this issue Nov 13, 2022 Discussed in #1319 · 2 comments · May be fixed by #2015
Open

Toggle task done command should add the global task filter text #1320

claremacrae opened this issue Nov 13, 2022 Discussed in #1319 · 2 comments · May be fixed by #2015
Labels
scope: commands Additions and changes to the commands supplied by Tasks scope: global filter Anything to do with the global filter type: enhancement New feature or request

Comments

@claremacrae
Copy link
Collaborator

Discussed in #1319

Originally posted by axelson November 13, 2022
Currently if you've set your Global task filter setting (i.e. to #task) then if you use the Toggle task done command you won't actually be creating a task unless you also manually type in #task. It would be nice if the Toggle task done command automatically added your Global task filter text.
@claremacrae claremacrae added type: enhancement New feature or request scope: commands Additions and changes to the commands supplied by Tasks labels Nov 13, 2022
@claremacrae
Copy link
Collaborator Author

Thanks for the suggestion.

I can't find any earlier requests for it.

At first I read this as if you were completing a task, but I think that you mean that if you have a line typed already, and then run Toggle task done it gains a checkbox but not a global filter, which means it will not show up in any task queries.

Good point, I agree.

@axelson
Copy link
Contributor

axelson commented Nov 14, 2022

Yes that's basically it, although usually I start from an empty line and run Toggle task done twice to create a task and I'd like that task to have the Global task filler task already inserted. Thanks!

@axelson axelson linked a pull request Jun 3, 2023 that will close this issue
Draft
16 tasks
@claremacrae claremacrae added the scope: global filter Anything to do with the global filter label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: commands Additions and changes to the commands supplied by Tasks scope: global filter Anything to do with the global filter type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Toggle task done command adds global filter text, if enabled axelson/obsidian-tasks
2 participants
@axelson @claremacrae