Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneNote - issue after sign in with version 1.6.1 #233

Open
fjacquet opened this issue Apr 9, 2024 · 8 comments
Open

OneNote - issue after sign in with version 1.6.1 #233

fjacquet opened this issue Apr 9, 2024 · 8 comments
Labels

Comments

@fjacquet
Copy link

fjacquet commented Apr 9, 2024

After a correct login to my M635 account, I face a TypeError blocking the enumeration of my Notebook :

typeerror cannot read properties of undefined (reading 'value')

Capture d’écran 2024-04-09 à 20 21 53

I don't have the skills to debug but I am happy to assist if needed. Did not find any similar issue in bounty.
Occurs on Mac and Win11

@enoola
Copy link

enoola commented Apr 9, 2024

Hello I experiment the same with macbook m3 (16-inch, Nov 2023) , I have HAR capture and console logs I can provide. HAR is quite sensitive so let me know.
Sonoma 14.4.1 (up to date when writing this)
tested with edge,chrome,safari
deactivated ublock, and few unrelated plugin, reduced tracking prevention from strict to balanced
nothing did it

@PetMudstone
Copy link

PetMudstone commented Apr 10, 2024

I am having a similar problem on Windows 10, using Firefox. It did briefly authorize properly and allow imports before this error suddenly started appearing after a few attempts. However, images would just fail to import on an arbitrary basis beforehand.

@kepano kepano added the onenote label Apr 15, 2024
@amyers1616
Copy link

Can confirm error on Linux and Windows 10 too.

@robbbyn
Copy link

robbbyn commented Apr 18, 2024

Same error for me on Firefox on Windows 10. Auth worked initially, however the Importer did not import properly; subsequent attempts to auth again then failed afterwards.

@GregHib
Copy link

GregHib commented Apr 19, 2024

Console log below, it's microsoft returning 429 (too many requests) after 5+ sign-ins. Importer doesn't seem to store and reuse the login token between imports even when pressing the "back" button after an import.

It also seems to occur when importing 50+ pages in one go.

OneNotes api is throttled to 5 concurrent requests per app per user: https://learn.microsoft.com/en-us/graph/throttling-limits#onenote-service-limits

Failed to load resource: the server responded with a status of 429 ()
An error has occurred while fetching an resource: 
{
    "error": {
        "code": "20166",
        "message": "The app has issued too many requests on behalf of this user in a short time period.",
        "innerError": {
            "date": "2024-04-19T14:39:21",
            "request-id": "c3bc1789-bd97-485b-8dfe-3bf943047d2e",
            "client-request-id": "c3bc1789-bd97-485b-8dfe-3bf943047d2e"
        }
    }
}
An error occurred while we were trying to sign you in. Error details:  TypeError: Cannot read properties of undefined (reading 'value')
    at Mr.showSectionPickerUI (plugin:obsidian-importer:214:1374)
    at async Mr.authenticateUser (plugin:obsidian-importer:214:716)

@GregHib
Copy link

GregHib commented Apr 19, 2024

This bug would be that the error isn't properly displayed to the user. The actual solution would be #117

@HavenAdventures
Copy link

I'm not even getting one import to work before getting this error. My issue does not to be related to a timeout

@enoola
Copy link

enoola commented May 29, 2024

I'm not even getting one import to work before getting this error. My issue does not to be related to a timeout
I have the same output as @fjacquet , but without a glance at it working at all.
so the error

{"An error has occurred while fetching an resource:",{"error":{"code":"10008","message":"One or more of the document libraries on the user or group's OneDrive contains more than 5,000 OneNote items (notebooks, sections, section groups) and cannot be queried using the API. Please make sure that none of the user or group's document libraries contains more than 5,000 OneNote items. Browse to this page for more information: https://blogs.msdn.microsoft.com/onenotedev/2016/09/11/onenote-api-calls-fail-with-a-large-number-of-items-in-a-sharepoint-document-library/","innerError":{"date":"2024-04-26T00:11:47","request-id":"81b24599-d7a6-4ed7-b569-036d3dfb4826","client-request-id":"81b24599-d7a6-4ed7-b569-036d3dfb4826"}}}

to note : " the user or group's OneDrive contains more than 5,000 OneNote items .. cannot be queried ..."
=> https://blogs.msdn.microsoft.com/onenotedev/2016/09/11/onenote-api-calls-fail-with-a-large-number-of-items-in-a-sharepoint-document-library

In essence I agree with @GregHib , pointing out the limitation and a link to the above would be a solution AFAIK.
now I need to find or make something to split my object across multiple users :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants