Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notion: Folders starting with a dot fails #87

Closed
Sire opened this issue Sep 4, 2023 · 6 comments
Closed

Notion: Folders starting with a dot fails #87

Sire opened this issue Sep 4, 2023 · 6 comments
Labels
bug Something isn't working notion

Comments

@Sire
Copy link

Sire commented Sep 4, 2023

caught (in promise) Error: Failed to create folder at "Notion/Dev/.NET Web/" at Bn.createFolders (plugin:obsidian-importer:18:2440) at async Bn.import (plugin:obsidian-importer:72:4554) at async HTMLButtonElement.eval (plugin:obsidian-importer:72:10602) createFolders @ plugin:obsidian-importer:18

@ericaxu ericaxu added bug Something isn't working notion labels Oct 13, 2023
@j-palindrome
Copy link
Contributor

j-palindrome commented Oct 25, 2023

Fixing with:

async createFolders(path: string): Promise<TFolder> {
		// can't create folders starting with a dot
		const sanitizedPath = path.replace(/^\./g, '').replace(/\/./g, '/')

@nonodesu
Copy link

nonodesu commented Nov 2, 2023

@joshuatazrein will that fix also handle folders that start with several dots in a row? For example I have some pages named '... continued'.

@j-palindrome
Copy link
Contributor

It's been updated to include several dots

@ericaxu
Copy link
Collaborator

ericaxu commented Nov 10, 2023

@joshuatazrein Can I close this issue now? Thanks!

@j-palindrome
Copy link
Contributor

Yep!

@kepano
Copy link
Collaborator

kepano commented Nov 15, 2023

Closed via 1.5.5

@kepano kepano closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working notion
Projects
None yet
Development

No branches or pull requests

5 participants