Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Smart Gantt #3368

Merged
merged 2 commits into from
May 27, 2024
Merged

Add plugin: Smart Gantt #3368

merged 2 commits into from
May 27, 2024

Conversation

nhannht
Copy link
Contributor

@nhannht nhannht commented Apr 12, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/nhannht/obsidian-smart-gantt

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Apr 16, 2024

"author": "Obsidian",
Update this.

"minAppVersion": "0.0.8",
That is way too low, set this to the latest public build number.

this.registerObsidianProtocolHandler("hello", async (_e) => {
Remove this.

this.app.workspace.detachLeavesOfType("smart-gantt")
Do not detach leaves with your custom view here, this is an antipattern, see: https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Don't+detach+leaves+in+%60onunload%60
Instead, only create a new leaf, if there is not one already.

return "Smart Gantt View";
Remove View here.

import mermaid from "mermaid";
Instead of importing Mermaid, use the laodMermaid function from the API, to avoid version drift.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Apr 16, 2024
@nhannht
Copy link
Contributor Author

nhannht commented Apr 16, 2024

Thank you.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You modified files other than community-plugins.json.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your theme submission

Errors:

❌ You modified files other than community-css-themes.json.
❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last theme in the list is: Ch0live/dunite. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add plugin: Smart Gantt Add theme: Dunite May 16, 2024
@github-actions github-actions bot added theme and removed Changes requested plugin Minor changes requested PR can be merged after some final changes have been requested labels May 16, 2024
@github-actions github-actions bot changed the title Add theme: Dunite Add plugin: Smart Gantt May 16, 2024
@nhannht
Copy link
Contributor Author

nhannht commented May 16, 2024

Sorry, I cannot understand how to solve the conflict in the community-plugins.json file when if it keeps receiving changes from other sources every day. 🙇

@joethei
Copy link
Collaborator

joethei commented May 21, 2024

You don't need to fix the merge conflicts, we will do that once the plugin is ready to be merged.

mermaid.initialize
This should not be necessary, mermaid.initialize is already being called by the loadMermaid function internally.
Or are there settings that need to be changed for the plugin to work correctly.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels May 21, 2024
@nhannht nhannht closed this May 23, 2024
@nhannht nhannht reopened this May 23, 2024
@nhannht
Copy link
Contributor Author

nhannht commented May 23, 2024

You don't need to fix the merge conflicts, we will do that once the plugin is ready to be merged.

mermaid.initialize This should not be necessary, mermaid.initialize is already being called by the loadMermaid function internally. Or are there settings that need to be changed for the plugin to work correctly.

I don't know but we need to call mermaid.initialize with startOnLoad:true to make it work. I am not sure what happened, may be because React using an isolated environment on its own.

This new commit added a new feature that doesn't relate to old problems.

@nhannht nhannht closed this May 23, 2024
@nhannht nhannht reopened this May 23, 2024
@nhannht
Copy link
Contributor Author

nhannht commented May 23, 2024

I also have no idea about the error:

Error: fatal: couldn't find remote ref refs/pull/3368/merge

Follow this thread I guess I will wait for you to manually check it

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels May 23, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token < in JSON at position 4684


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei joethei merged commit e71b6ea into obsidianmd:master May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants