Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: You and Your Research #3687

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Conversation

neozhang
Copy link
Contributor

Submitting a new plugin with the ID "you-and-your-research".

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/neozhang/you-and-your-research

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ] in JSON at position 439066


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 0.9.5.1. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Your latest Release is missing the main.js file.
❌ Your latest Release is missing the manifest.json file.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add You and Your Research plugin Add plugin: You and Your Research Jun 12, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1]:Obsidian provides the requestUrl method, it will make sure that network requests work on every plattform.

[1]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.

@neozhang
Copy link
Contributor Author

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Optional

[1]:Obsidian provides the requestUrl method, it will make sure that network requests work on every plattform.

[1]:Casting to any should be avoided as much as possible.

Do NOT open a new PR for re-validation.

these issues have been resolved in the latest release (0.9.7)

@joethei
Copy link
Collaborator

joethei commented Jun 13, 2024

console.log(data.choices[0].message.content);
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

const yaml = require("js-yaml");
To change frontmatter use the processFrontmatter function.

new Setting(containerEl).addButton((button) =>
This serves no purpose, remove it.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jun 13, 2024
@neozhang
Copy link
Contributor Author

console.log(data.choices[0].message.content);

Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

const yaml = require("js-yaml");

To change frontmatter use the processFrontmatter function.

new Setting(containerEl).addButton((button) =>

This serves no purpose, remove it.

Thanks for the comments. Please review my latest code. I believe that it doesn't include any of the issues as you mentioned. Thank you.

@neozhang
Copy link
Contributor Author

Please check the latest release at: https://github.com/neozhang/you-and-your-research/releases/tag/0.9.8

@joethei joethei added Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jun 21, 2024
@joethei joethei merged commit a13a821 into obsidianmd:master Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants