Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Another Sticky Headings #3717

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

zhouhua
Copy link
Contributor

@zhouhua zhouhua commented Jun 17, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/zhouhua/obsidian-sticky-headings

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ There is already a plugin with the name Sticky Headings.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title add sticky headings plugin Add plugin: Another Sticky Headings Jun 18, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2]:You should not cast this, instead use a instanceof check to make sure that it's actually a file/folder.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Jun 18, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jun 18, 2024
@zhouhua
Copy link
Contributor Author

zhouhua commented Jun 18, 2024

/skip

I have fixed the issues mentioned above, but it didn't automatically trigger a recheck.

@github-actions github-actions bot added the Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong label Jun 18, 2024
@zhouhua
Copy link
Contributor Author

zhouhua commented Jun 18, 2024

image

@joethei The GitHub Action encountered an error and couldn't automatically assign a reviewer. Could you please help review it?

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ There is already a plugin with the name Sticky Headings.
❌ Plugin ID mismatch, the ID in this PR (sticky-headings) is not the same as the one in your repo (another-sticky-headings). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Plugin name mismatch, the name in this PR (Sticky Headings) is not the same as the one in your repo (Another Sticky Headings). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@zhouhua
Copy link
Contributor Author

zhouhua commented Jun 21, 2024

@joethei Could you help review this plugin?

@joethei
Copy link
Collaborator

joethei commented Jun 21, 2024

A screenshot in the README would be good.

@joethei joethei assigned joethei and unassigned ObsidianReviewBot Jun 21, 2024
@joethei joethei added Minor changes requested PR can be merged after some final changes have been requested and removed Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong labels Jun 21, 2024
@zhouhua
Copy link
Contributor Author

zhouhua commented Jun 23, 2024

Yeah, I've add some GIFs to show the features.

@joethei joethei removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jun 24, 2024
@joethei joethei merged commit b4ce647 into obsidianmd:master Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants