Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: File Flex #3728

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

19msb
Copy link
Contributor

@19msb 19msb commented Jun 19, 2024

This pull request adds the File Flex plugin, which provides customisable undo functionality for file and folder movements and renames within Obsidian. Users can easily revert changes to their vault structure with a single click and/or hotkey.

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/19msb/obsidian-file-flex

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Plugin: File Flex Add plugin: File Flex Jun 19, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token : in JSON at position 441116


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: quorafind/obsidian-search-in-canvas. If you are submitting from a GitHub org, you need to be a public member of the org.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Jun 21, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jun 21, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jun 21, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@19msb
Copy link
Contributor Author

19msb commented Jun 21, 2024

Hi @joethei
Should I move main.js to .gitignore?
I am confused by the instructions to do so that were followed by them seeming to be revoked.

@joethei
Copy link
Collaborator

joethei commented Jun 21, 2024

The main.js should be removed from the repo and added to the gitignore, not sure why the bot always ignores that.

@joethei
Copy link
Collaborator

joethei commented Jun 24, 2024

Where is the actual source code?
Or did you put all of the code into the main.js?
In that case the bot should not have flagged it at all, as the code should be in the repo.

@19msb
Copy link
Contributor Author

19msb commented Jun 24, 2024

@joethei

Haha, yes. All of the code is in the main.js.
I've added it back to the repo.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jun 24, 2024
@19msb
Copy link
Contributor Author

19msb commented Jun 25, 2024

@joethei
thanks. all set!
let me know if there is anything else

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Minor changes requested PR can be merged after some final changes have been requested labels Jun 25, 2024
@joethei
Copy link
Collaborator

joethei commented Jun 25, 2024

- On Windows: %APPDATA%/Roaming/obsidian/plugins
These paths are not correct, users can decide where they want to place their vault.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review Changes made labels Jun 25, 2024
@19msb
Copy link
Contributor Author

19msb commented Jun 25, 2024

@joethei
Thank you!
I've updated the installation details to address customisation of plugins folder location and the capability of installing through obsidian.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jun 25, 2024
This pull request adds the File Flex plugin, which provides customisable undo functionality for file and folder movements and renames within Obsidian. Users can easily revert changes to their vault structure with a single click and/or hotkey.
@joethei joethei merged commit a42aa85 into obsidianmd:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants