-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: Syrinscape Online Player #3730
Conversation
Hello!I found the following issues in your plugin submission Errors: ❌ Please don't include This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ Please don't include This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ Could not parse This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1]:Using Optional[1]:Casting to Do NOT open a new PR for re-validation. |
Changes requested by bot have been made, assigning human for additional review. |
@joethei - I keep rebasing to eliminate merge conflicts in the PR in order to make your review easier. Is that something you want/expect me to do? Or does that make your job more difficult? |
You don't need to keep rebasing, I will do that before merging. |
authToken: 'insert-your-auth-token-here', const response = await fetch(apiUrl, { containerEl.createEl('h2', { text: 'Syrinscape Plugin Settings' }); .setName('Auth Token'), .setName('Cache Age'), .setName('Trigger Word'), .setName('Clear Remote Links'), .setButtonText('Clear Remote Links') |
@joethei - do I remove the 'changes requested' labels, or do you? I have addressed your comments, closed and re-opened the MR and thought perhaps the bot would make the changes. edit: I think I discovered the answer. I don't have access to remove the labels. :D |
The bot rescans every couple of hours, and will update the labels if all of the required changes have been made. |
Syrinscape is a TTRPG tool for ambient sounds. This plugin will allow GMs to control the Syrinscape online player from inside of notes, triggering moods and one-shot sounds.
Syrinscape is a TTRPG tool for ambient sounds. This plugin will allow GMs to control the Syrinscape online player from inside of notes, triggering moods and one-shot sounds.
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/scooper4711/obsidian-syrinscape
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.