Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Syrinscape Online Player #3730

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

scooper4711
Copy link
Contributor

Syrinscape is a TTRPG tool for ambient sounds. This plugin will allow GMs to control the Syrinscape online player from inside of notes, triggering moods and one-shot sounds.

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/scooper4711/obsidian-syrinscape

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't include Obsidian in the plugin description
❌ The authorUrl field in your manifest should not point to the GitHub repository of the plugin.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't include Obsidian in the plugin description


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected string in JSON at position 442009


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Submit community plugin for syrinscape Add plugin: Syrinscape Online Player Jun 19, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements


Optional

[1]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Jun 20, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jun 20, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jun 21, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jun 21, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@scooper4711
Copy link
Contributor Author

@joethei - I keep rebasing to eliminate merge conflicts in the PR in order to make your review easier. Is that something you want/expect me to do? Or does that make your job more difficult?

@joethei
Copy link
Collaborator

joethei commented Jun 24, 2024

You don't need to keep rebasing, I will do that before merging.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jun 24, 2024
@scooper4711 scooper4711 reopened this Jun 24, 2024
@scooper4711
Copy link
Contributor Author

scooper4711 commented Jun 24, 2024

@joethei - do I remove the 'changes requested' labels, or do you? I have addressed your comments, closed and re-opened the MR and thought perhaps the bot would make the changes.

edit: I think I discovered the answer. I don't have access to remove the labels. :D

@joethei
Copy link
Collaborator

joethei commented Jun 24, 2024

The bot rescans every couple of hours, and will update the labels if all of the required changes have been made.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jun 24, 2024
Syrinscape is a TTRPG tool for ambient sounds. This plugin will
allow GMs to control the Syrinscape online player from inside of
notes, triggering moods and one-shot sounds.
@joethei joethei merged commit f0c4fe5 into obsidianmd:master Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants