Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Edit in Neovim #3734

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Add plugin: Edit in Neovim #3734

merged 2 commits into from
Jul 1, 2024

Conversation

TheseusGrey
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin:

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ] in JSON at position 443434


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add "Edit in Neovim" plugin Add plugin: Edit in Neovim Jun 21, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Jun 24, 2024

Copyright (c) [year] [fullname]
Fill this.

"fundingUrl": "",
If you don't have such a link remove this line.

.setName('Neovim Server Location')
Use sentence case in UI

Remove the styles.css file from your release, since it's empty it's just unnecessary bloat.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jun 24, 2024
@TheseusGrey
Copy link
Contributor Author

Copyright (c) [year] [fullname]
Fill this.

I've addressed all the other comments 🙂 I did fill in the name using my github username if that's okay? otherwise I can find an alternative license with similar points that doesn't require an explicit name in it.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jun 28, 2024
@joethei joethei merged commit c1b8b34 into obsidianmd:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants