Stream.plot(type='section') does not respect method='full'

[liamtoney]

Avoid duplicates

• I searched existing issues

Bug Summary

When using the Stream plotting method with type='section', no matter the method used the data are resampled if they exceed 10,000 samples, see here in the __init__() method for WaveformPlotting:

obspy/obspy/imaging/waveform.py

Lines 125 to 129 in 00122ed

	if self.type == 'section':
	# section may consists of hundreds of seismograms
	self.max_npts = 10000
	else:
	self.max_npts = 400000

and in __sect_init_traces():

obspy/obspy/imaging/waveform.py

Lines 1235 to 1239 in 00122ed

	for _i, tr in enumerate(self.stream):
	if len(tr.data) >= self.max_npts:
	tmp_data = signal.resample(tr.data, self.max_npts)
	else:
	tmp_data = tr.data

It seems to me that the latter bit of code should be checking if method='full' and if so, setting tmp_data = tr.data — rather than resampling. Currently that kwarg is not checked. Therefore, as it stands, users have no way of fully plotting the data without resampling if they're using type='section'.

I'm happy to make a PR to address this.

Code to Reproduce

No response

Error Traceback

No response

ObsPy Version?

1.4.0

Operating System?

macOS (M1)

Python Version?

3.11.5

Installation Method?

conda

[megies]

I'm happy to make a PR to address this.

Sure, go ahead!

[liamtoney]

Great. What branch should I base my feature branch off of? maintenance_1.4.x?

[megies]

Great. What branch should I base my feature branch off of? maintenance_1.4.x?

Yes. Qualifies as a "bug", so that's where I would base it off of.

[liamtoney]

Closing this seeing as #3379 was merged.

[megies]

Closing this seeing as #3379 was merged.

github does close stuff automatically, but when the PR goes into maintenance branch it will only close the related issue after maintenance is merged into master, which will happen eventually but sometimes not immediately 👍

[liamtoney]

when the PR goes into maintenance branch it will only close the related issue after maintenance is merged into master

Ah! Didn't know this. Thanks.