[contract_payment_auto] Lack of robustness - missing commits after each payment (?) #166
Comments
|
No, that's not a good technique. You should never commit inside a transaction, or you can have an inconsistent situation. |
|
Hello @pedrobaeza thanks for your answer. However, present issue describes a problem (global rollback of operations that are independent by nature) which is not solved, so I don't think it should be closed so fast as there is room for improvement here. The What do you think? |
|
@nhomar why do you reopen? You know that there should never be a commit in the middle of the operation. |
…action on recurring invoice creation and auto pay retry errors Fixes OCA#166. Rather save the database state before each invoice creation (or auto pay retry) so that only those in failure are rollbacked. Before the change, the whole transaction was rollbacked on error although the recurring invoice creations (resp. auto pay retries) are independant operations. This was leading to specially bad bugs when using an HTTP-driven service for auto payments, as the service could register payments that odoo would rollback on a later invoice creation crash in the same cron execution, thus auto paying them again at next cron execution although they were already registered as paid in the distant service.
|
Closing as there's an opened PR about this and being discussed there. |
Hi folks,
I recently faced an important issue (see #165) which rolled back the creation of a bunch of payment transactions in odoo, while their acquirer counterpart operations were sent to the bank. At next cron execution time, all these operations were then re-executed, resulting in a double bank payment.
The consequences would have been mitigated if a commit had been executed in the recurring task loop. Do you agree? Where in the code would you put that commit? In
AccountAnalyticAccount.recurring_create_invoicein contract/models/account_analytic_account.py? Any advice before I give it a try and submit a pull request?The text was updated successfully, but these errors were encountered: