-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] website_sale_checkout_skip_payment not compatible with delivery methods #741
Comments
The issue happens at the last step But when the customer is allowed to skip_payment, the JS code throws an error at this line :
so the method is not tiggered, the carrier is not updated, and the first one on the list is used. I think this might be because the payment route is skipped and we go directly to the confirmation route (like below). e-commerce/website_sale_checkout_skip_payment/views/website_sale_template.xml Lines 14 to 18 in d049af5
However I don't have a clearer idea. |
Sorry @victor-champonnois The website_sale_checkout_skip_payment module has not include any JS code, so I think that this error is related to other module... |
@sergio-teruel I took a look and it seems to be related to the absence of the payment button element. https://github.com/odoo/odoo/blob/c53081f10befd4f1c98e46a450ed3bc71a6246ed/addons/website_sale_delivery/static/src/js/website_sale_delivery.js#L12 Anyway, I couldn't reproduce the bug in the versions we're currently supporting for our customers (>13). So @victor-champonnois feel free to propose a PR patching de issue for 12.0 |
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Module
website_sale_checkout_skip_payment
Tested on version 12 Community Edition
Describe the bug
When buying product from eCommerce, I select a delivery method available (not the first one). On the Sale Order in backend, the wrong delivery method is selected. It's always the first one in the list of delivery methods configuration that is selected on the SO.
To Reproduce
Affected versions: version 12
Steps to reproduce the behavior:
Expected behavior
![Delivery Methods - Odoo](https://user-images.githubusercontent.com/27895270/215143974-70e92be9-ee2f-4812-b693-fe7582cea92d.png)
![SO002 - wrong delivery method in backend - Odoo](https://user-images.githubusercontent.com/27895270/215143943-f16378c3-f7fc-414a-a13b-47f71cb38695.png)
![Administrator_customer_config_skip - Odoo](https://user-images.githubusercontent.com/27895270/215143951-9a09475f-6eba-47cc-bf0a-a816a9c47e11.png)
![Payment My Website_Delivery](https://user-images.githubusercontent.com/27895270/215143964-da818489-e930-4c20-b181-1fece0aff319.png)
6. The delivery method chosen by the customer on the eCommerce is selected o
n the SO on the backend
The text was updated successfully, but these errors were encountered: