Red branch because of use builtin names

[bealdav]

Some branch are red because of code like here in v12

https://travis-ci.org/github/OCA/edi/jobs/663059314#L325-L328

base_ubl/models/ubl.py:57: [W0622(redefined-builtin), BaseUbl._ubl_add_address] Redefining built-in 'zip'

base_ubl/models/ubl.py:286: [W0622(redefined-builtin), BaseUbl._ubl_add_line_item] Redefining built-in 'type'

base_ubl/models/ubl.py:329: [W0622(redefined-builtin), BaseUbl._ubl_add_item] Redefining built-in 'type'

base_ubl/models/ubl.py:609: [W0622(redefined-builtin), BaseUbl.ubl_parse_address] Redefining built-in 'zip'

I propose to rename zip var or arg in zip_ and type in type_

It could break some method calls in case of named argument like here
https://github.com/OCA/edi/blob/12.0/base_ubl/models/ubl.py#L323-L329

but sure we'll at to fix it

What do you think ?

Thanks for sharing your ideas @astirpe @SimoRubi @lmignon @tarteo @alexis-via @joshuajan @feketemihai @acsonefho @rousseldenis @luc-demeyer @Cedric-Pigeon

[SimoRubi]

In my opinion, I'd rather rename the variables/arguments with something that explains their meaning.
In your example

edi/base_ubl/models/ubl.py

Lines 323 to 329 in 742b131

	self._ubl_add_item(
	name, product, line_item, ns, type=type, seller=seller,
	version=version)
	@api.model
	def _ubl_add_item(
	self, name, product, parent_node, ns, type='purchase',

type could be renamed to line_type or something similar.

[astirpe]

@bealdav looking at the link to the travis log that you posted, it seems to me that the red branch is caused by the following error only:

************* Module account_e-invoice_generate

account_e-invoice_generate/readme/INSTALL.rst:6: [E7901(rst-syntax-error), ]  Duplicate explicit target name: "oca/edi".

------------


count_errors 1

pylint expected errors 0, found 1!

[bealdav]

You're right @astirpe
pylint fixed by #186
Could you merge ?

[bealdav]

OK green now, but we should note to not use builtin names in method for the future