Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] hr_holidays_settings: duplicated in OCA / hr-holidays repo #1256

Closed
javimurcia opened this issue Jun 14, 2023 · 2 comments · Fixed by #1257
Closed

[14.0] hr_holidays_settings: duplicated in OCA / hr-holidays repo #1256

javimurcia opened this issue Jun 14, 2023 · 2 comments · Fixed by #1257
Labels

Comments

@javimurcia
Copy link

The repo OCA / hr-holidays also has an addon called hr_holidays_settings, which appears to be functionally identical

Module

hr_holidays_settings

Expected behavior
If both addons are the same, as it appears to be the case, then one of them should be removed, if not, one of them should be renamed

Additional context
Add any other context about the problem here. (e.g. OS, Python version, ...)

@javimurcia javimurcia added the bug label Jun 14, 2023
@JordiMForgeFlow
Copy link

The module was migrated to 14.0 on #1111 (not sure why it was moved to the hr repository). In V13, however, the module is in the hr-holidays repo so it is why it was also migrated there on OCA/hr-holidays#77.

They are both the same so I think one of them should be removed. WDYT @pedrobaeza @MiquelRForgeFlow @nimarosa ?

@pedrobaeza
Copy link
Member

The one on OCA/hr is incorrect. There was a split in v13 of OCA/hr into OCA/hr, OCA/hr-holidays, OCA/hr-expense and OCA/hr-attendance, but hr_holidays_settings was already in v13 in OCA/hr-holidays, so I don't know why the migration in OCA/hr.

Please revert such migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants