Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] maintenance_plan and muticompany scheme issue #135

Closed
dalonsod opened this issue Jul 5, 2021 · 2 comments
Closed

[12.0] maintenance_plan and muticompany scheme issue #135

dalonsod opened this issue Jul 5, 2021 · 2 comments

Comments

@dalonsod
Copy link
Contributor

dalonsod commented Jul 5, 2021

Hello,

I've got a v12 installation of maintenance_plan prior to 12.0.2.3.0. This version adds some new features for plans, like a specific view and menu, which shows plans together.

Plans still haven't company_id field, so in this view you can see plans linked to equipments of other companies, and a permission error is raised when accessing to it. And equipment is not a required field for plans.

For this situation, which is the more suitable solution, adding a domain filter for thar view in order to prevent accessing to "forbidden" plans, or directly adding company_id field for plans?

cc @etobella @AdriaGForgeFlow

@dalonsod
Copy link
Contributor Author

dalonsod commented Jul 7, 2021

I've added a multi-company global rule for plans, pointing to equipment company, and it seems to work. If that's the proper solution, I'll make a PR

@dalonsod
Copy link
Contributor Author

Implemented in #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant