Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] report_py3o: make escape_false=True work on ODS reports #124

Closed
alexis-via opened this issue Apr 12, 2017 · 2 comments
Closed

[10.0] report_py3o: make escape_false=True work on ODS reports #124

alexis-via opened this issue Apr 12, 2017 · 2 comments
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@alexis-via
Copy link
Contributor

With ODT py3o reports, thanks to an enhancement made several months ago by @lmignon in report_py3o (cf https://github.com/OCA/reporting-engine/blob/10.0/report_py3o/models/py3o_report.py#L244) and py3o.template, an empty field displayed in the ODT report is not displayed as "False" but as an empty value.

It would be great to have the same in ODS report. Currently, to avoid to display "False" when the email is empty we have to use in the ODS template : ${o.email or ''}

@alexis-via
Copy link
Contributor Author

Our conclusion is that we can't have the escape_false=True behavior for ODS reports. This is because the fields such as ${o.email} is a raw genshi expression, which is rendered in py3o.template by MarkupTemplate(), and there is no way to tell MarkupTemplate() to render False expressions as empty string.

@faide Do you confirm our point of view ? Otherwise, do you have an idea how to make escape_false=True work on ODS templates ?

SimoneVagile pushed a commit to SimoneVagile/reporting-engine that referenced this issue Jan 25, 2021
Signed-off-by pedrobaeza
@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

1 participant