Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] Tier validation subtype of messages #125

Closed
CasVissers-360ERP opened this issue Feb 12, 2020 · 1 comment · Fixed by #127
Closed

[13.0] Tier validation subtype of messages #125

CasVissers-360ERP opened this issue Feb 12, 2020 · 1 comment · Fixed by #127

Comments

@CasVissers-360ERP
Copy link

def _notify_accepted_reviews(self):
def _notify_rejected_review(self):

both these methods use subtype="mt_comment" which I think is incorrect.

In for example a purchase order workflow we don't want to send a message to the supplier of the PO (which also follower) if a PO is internally rejected or approved.

I suggest I create a PR to change the subtype to mt_note.

@LoisRForgeFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants