Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] web_ckeditor4 javascript error in Webkit based navigators when saving #176

Closed
lefeverd opened this issue Jul 14, 2015 · 1 comment
Closed

[8.0] web_ckeditor4 javascript error in Webkit based navigators when saving #176

lefeverd opened this issue Jul 14, 2015 · 1 comment
Assignees
@StefanRijnhart

Comments

@lefeverd
Copy link

module: web_ckeditor4
version: 8.0

Steps to reproduce

  • Open a record containing a text_html widget in a Webkit based navigator (Chrome, Safari)
  • Edit, leave the value in the text_html empty
  • Save

Current behaviour
It raises the following error:
TypeError: undefined is not an object (evaluating 'self.editor.name').

Expected behaviour
The record should be saved without errors

/cc @StefanRijnhart
lefeverd referenced this issue Jul 14, 2015
[FIX] Destroy the editor properly. This prevents errors like
a804099 
'this.getWindow(...).$ is undefined' in Firefox after closing
a popup containing an editor instance.
was opened in a popup window.
StefanRijnhart pushed a commit to StefanRijnhart/web that referenced this issue Jul 23, 2015
[FIX] Now that we actually destroy editors, we need another check for…
e8da6a9 
… their currentness

Fixes OCA#176
@StefanRijnhart StefanRijnhart mentioned this issue Jul 23, 2015
Merged
@StefanRijnhart StefanRijnhart self-assigned this Jul 23, 2015
@StefanRijnhart
Copy link
Member

@lefeverd can you test #186 and post your review? I have set it to Work-in-progress until I have your confirmation that this fixes the issue.

thomaspaulb pushed a commit to thomaspaulb/web that referenced this issue Dec 5, 2016
@thomaspaulb
[FIX] Now that we actually destroy editors, we need another check for…
16d936b 
… their currentness

Fixes OCA#176
vrenaville pushed a commit to camptocamp/web that referenced this issue Jul 19, 2018
@Tonow-c2c
Merge pull request OCA#176 from Tonow-c2c/BIZ-1581_add_line_breaks_on…
71dde70 
…_customer_invoice

BIZ-1581: add 3 lines breaks on invoice report
ivantodorovich pushed a commit to camptocamp/web that referenced this issue Nov 16, 2021
@ivantodorovich
[FIX] Now that we actually destroy editors, we need another check for…
1cdc159 
… their currentness

Fixes OCA#176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanRijnhart StefanRijnhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefanRijnhart @lefeverd