Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate worksheet fields test #1625

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

razvan-pro
Copy link
Collaborator

@razvan-pro razvan-pro commented Feb 22, 2022

This change is Reviewable

Copy link
Contributor

@dionizh dionizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)


aimmo/tests/test_migration_worksheet_model.py, line 58 at r1 (raw file):

@pytest.mark.django_db
def test_worksheet_has_new_pdf_name_fields(migrator):

Just a note that we should probably get rid of this pdf field now that we don't use pdfs anymore.

Copy link
Collaborator Author

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)


aimmo/tests/test_migration_worksheet_model.py, line 58 at r1 (raw file):

Previously, dionizh (Dioni Zhong) wrote…

Just a note that we should probably get rid of this pdf field now that we don't use pdfs anymore.

True 🙂

@razvan-pro razvan-pro changed the base branch from development to master February 23, 2022 11:35
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1625 (a0f9308) into master (f97e528) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1625   +/-   ##
=======================================
  Coverage   67.98%   67.98%           
=======================================
  Files         164      164           
  Lines        3330     3330           
  Branches      280      280           
=======================================
  Hits         2264     2264           
  Misses       1038     1038           
  Partials       28       28           

@razvan-pro razvan-pro merged commit 2d34ed2 into master Feb 23, 2022
@razvan-pro razvan-pro deleted the fix-duplicate-name-test branch February 23, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants