Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Simplify CI flow and use master only #1626

Merged
merged 2 commits into from
Feb 22, 2022
Merged

fix: Simplify CI flow and use master only #1626

merged 2 commits into from
Feb 22, 2022

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Feb 22, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Feb 22, 2022
Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


.github/workflows/ci.yml, line 4 at r1 (raw file):

on:
  release:
    types: [ published ]

Are you using prettier? It removes this space for me 🤔

Copy link
Member Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @razvan-pro)


.github/workflows/ci.yml, line 4 at r1 (raw file):

Previously, razvan-pro (Razvan Mahu) wrote…

Are you using prettier? It removes this space for me 🤔

No I don't have prettier setup

Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1626 (3688c47) into master (aeeda78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1626   +/-   ##
=======================================
  Coverage   67.98%   67.98%           
=======================================
  Files         164      164           
  Lines        3330     3330           
  Branches      280      280           
=======================================
  Hits         2264     2264           
  Misses       1038     1038           
  Partials       28       28           

@faucomte97 faucomte97 merged commit 586fa02 into master Feb 22, 2022
@faucomte97 faucomte97 deleted the trim_ci_flow branch February 22, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants