Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add worksheet 4 #1651

Merged
merged 4 commits into from
May 5, 2022
Merged

feat: add worksheet 4 #1651

merged 4 commits into from
May 5, 2022

Conversation

KamilPawel
Copy link
Collaborator

@KamilPawel KamilPawel commented May 4, 2022

This change is Reviewable

Copy link
Contributor

@dionizh dionizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @KamilPawel)


pyproject.toml line 3 at r2 (raw file):

[build-system]
requires = ["setuptools", "wheel"]
build-backend = "setuptools.build_meta:__legacy__"

Can you check portal for the same file and add the black line length of 120?§


aimmo/worksheets.py line 182 at r2 (raw file):

#    Task 2: Examine all artefacts
#       - Write some code that prints the position of your backpack and
#         the item that is in that position.

Write some code that outputs the position and description of each of the artefact in your backpack


aimmo/worksheets.py line 185 at r2 (raw file):

#
#    Task 3: Count your loot
#       - Count how many of each artifacts do you have

Count how many you have of each artefact


aimmo/worksheets.py line 193 at r2 (raw file):

#       - avatar_state.backpack
#       - avatar_state.location
#       - world_state.get_cell(avatar_location)

These 3 are not new so we can remove them I think.


aimmo/worksheets.py line 194 at r2 (raw file):

#       - avatar_state.location
#       - world_state.get_cell(avatar_location)
#       - DropAction(index)

Add: backpack.find(ARTEFACT)

Copy link
Contributor

@dionizh dionizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)


pyproject.toml line 3 at r2 (raw file):

Previously, dionizh (Dioni Zhong) wrote…

Can you check portal for the same file and add the black line length of 120?§

[tool.black]
line-length = 120

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1651 (f26f4be) into master (29ae2e7) will increase coverage by 19.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1651       +/-   ##
===========================================
+ Coverage   68.06%   87.59%   +19.53%     
===========================================
  Files         165       36      -129     
  Lines        3338     1016     -2322     
  Branches      278      154      -124     
===========================================
- Hits         2272      890     -1382     
+ Misses       1038      102      -936     
+ Partials       28       24        -4     
Impacted Files Coverage Δ
aimmo-game/simulation/worksheet/worksheet.py 78.26% <ø> (ø)
aimmo-game/simulation/game_runner.py 69.84% <100.00%> (-0.93%) ⬇️
...e/simulation/worksheet/avatar_state_serializers.py 100.00% <100.00%> (ø)
aimmo-game/setup.py
aimmo/views.py
aimmo/worksheets.py
game_frontend/src/pyodide/webWorker.ts
...ame_frontend/src/redux/features/Analytics/index.js
...ntend/src/redux/features/AvatarWorker/operators.js
aimmo/migrations/0014_add_worksheet_model.py
... and 122 more

Copy link
Contributor

@dionizh dionizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)

@dionizh dionizh changed the base branch from master to worksheet4 May 5, 2022 14:34
Copy link
Contributor

@dionizh dionizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@dionizh dionizh merged commit deb36f1 into worksheet4 May 5, 2022
@dionizh dionizh deleted the modern_era branch May 5, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants