-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add worksheet 4 #1651
feat: add worksheet 4 #1651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @KamilPawel)
pyproject.toml
line 3 at r2 (raw file):
[build-system] requires = ["setuptools", "wheel"] build-backend = "setuptools.build_meta:__legacy__"
Can you check portal for the same file and add the black line length of 120?§
aimmo/worksheets.py
line 182 at r2 (raw file):
# Task 2: Examine all artefacts # - Write some code that prints the position of your backpack and # the item that is in that position.
Write some code that outputs the position and description of each of the artefact in your backpack
aimmo/worksheets.py
line 185 at r2 (raw file):
# # Task 3: Count your loot # - Count how many of each artifacts do you have
Count how many you have of each artefact
aimmo/worksheets.py
line 193 at r2 (raw file):
# - avatar_state.backpack # - avatar_state.location # - world_state.get_cell(avatar_location)
These 3 are not new so we can remove them I think.
aimmo/worksheets.py
line 194 at r2 (raw file):
# - avatar_state.location # - world_state.get_cell(avatar_location) # - DropAction(index)
Add: backpack.find(ARTEFACT)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)
pyproject.toml
line 3 at r2 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Can you check portal for the same file and add the black line length of 120?§
[tool.black]
line-length = 120
Codecov Report
@@ Coverage Diff @@
## master #1651 +/- ##
===========================================
+ Coverage 68.06% 87.59% +19.53%
===========================================
Files 165 36 -129
Lines 3338 1016 -2322
Branches 278 154 -124
===========================================
- Hits 2272 890 -1382
+ Misses 1038 102 -936
+ Partials 28 24 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
This change is