feat: add DropAction #1656
feat: add DropAction #1656
Conversation
There was a problem hiding this comment.
Reviewed 10 of 11 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dionizh)
aimmo-game/simulation/action.py line 106 at r2 (raw file):
self.avatar.add_event(FailedDropEvent()) self.avatar.clear_action() self.avatar.logs.append("Uh oh! Your avatar was unable to drop the artefact on that position!")
Could this say "at that position"? the "on" confused me for a bit
aimmo-game-worker/simulation/world_map.py line 13 at r2 (raw file):
SCAN_LIMIT = 3 SCAN_RADIUS = 12 ARTEFACT_TYPES = ["chest", "key", "yellow_orb", "phone", "keyboard", "coins"]
How come I'm seeing changes linked to artefacts in this PR?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dionizh)
a discussion (no related file):
I know we discussed this before in a meeting but what's the feedback when the user drops an artefact? Does anything happen on screen? Do logs show in the console saying they've dropped something?
There was a problem hiding this comment.
Reviewed 10 of 11 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dionizh and @faucomte97)
a discussion (no related file):
Previously, faucomte97 (Florian Aucomte) wrote…
I know we discussed this before in a meeting but what's the feedback when the user drops an artefact? Does anything happen on screen? Do logs show in the console saying they've dropped something?
Oh, good question - it should probably show something in logs? I remember we discussed not to show it on the map, so they should have some other feedback.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @faucomte97)
a discussion (no related file):
Previously, razvan-pro (Razvan Mahu) wrote…
Oh, good question - it should probably show something in logs? I remember we discussed not to show it on the map, so they should have some other feedback.
Added log!
aimmo-game/simulation/action.py line 106 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Could this say "at that position"? the "on" confused me for a bit
Done. (I was thinking on the square at first, but changed the last bit, and forgot to change the on.)
aimmo-game-worker/simulation/world_map.py line 13 at r2 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
How come I'm seeing changes linked to artefacts in this PR?
Yeah forgot the coins before!
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dionizh)
There was a problem hiding this comment.
Reviewable status:
Codecov Report
@@ Coverage Diff @@
## worksheet4 #1656 +/- ##
=============================================
Coverage ? 68.00%
=============================================
Files ? 165
Lines ? 3376
Branches ? 283
=============================================
Hits ? 2296
Misses ? 1053
Partials ? 27 |
This change is