Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add worksheet 4 student challenge url #1663

Merged
merged 2 commits into from
May 19, 2022
Merged

Conversation

razvan-pro
Copy link
Collaborator

@razvan-pro razvan-pro commented May 19, 2022

This change is Reviewable

@razvan-pro razvan-pro self-assigned this May 19, 2022
Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @razvan-pro)


aimmo/worksheets.py line 224 at r1 (raw file):

""",
        active_image_path="images/worksheets/modern_active.png",
        description="After successfully collecting all the missing artefacts from the first time checkpoint, you arrive at what looks like the 21st century. You recognise some cars parked here and there, old-fashioned roads and houses like the ones your history teacher told you about. On the bright side, you seem to be alone and safe to walk around... for now. A more recent timeline doesn’t make artefacts easier to find, though. Or at least not the right ones. In this timeline there seems to be an amount of falsified objects that resemble the ones you’re looking for, but aren’t quite genuine. These will have no value in the museum. Your navigation system will be able to tell you whether an object is genuine or not, but it’s up to you to decide which ones to bring back!",

Yeaaah this needs to be reviewed and changed. It's not relevant to what the worksheet is anymore.
I'd have something like:

After successfully collecting all the missing artefacts from the first time checkpoint, you arrive at what looks like the 21st century. You recognise some cars parked here and there, just like the ones your history teacher told you about. A more recent timeline doesn’t make artefacts easier to find, though. Or at least not the right ones. In this timeline there seems to be some object which will have no value in the museum. Your navigation system will be able to tell you whether an object is genuine or not, but it’s up to you to decide which ones to bring back!

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1663 (e5a4136) into master (7299ab3) will increase coverage by 19.98%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1663       +/-   ##
===========================================
+ Coverage   67.98%   87.97%   +19.98%     
===========================================
  Files         165       38      -127     
  Lines        3377     1048     -2329     
  Branches      283      159      -124     
===========================================
- Hits         2296      922     -1374     
+ Misses       1054      103      -951     
+ Partials       27       23        -4     
Impacted Files Coverage Δ
aimmo/worksheets.py
aimmo/csp_config.py
game_frontend/src/components/icons/Play.js
game_frontend/src/containers/Game/index.js
aimmo/templatetags/players_utils.py
aimmo/serializers.py
aimmo/migrations/0011_reset_game_tokens.py
game_frontend/src/babylon/interfaces.ts
game_frontend/src/components/Code/index.js
...ame_frontend/src/babylon/assetPacks/wrongFuture.ts
... and 119 more

@razvan-pro razvan-pro enabled auto-merge (squash) May 19, 2022 13:43
@razvan-pro razvan-pro merged commit 7dd5b30 into master May 19, 2022
@razvan-pro razvan-pro deleted the worksheet4-student-url branch May 19, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants