Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Refine templates #1667

Merged
merged 5 commits into from
Jun 1, 2022
Merged

docs: Refine templates #1667

merged 5 commits into from
Jun 1, 2022

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented May 27, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this May 27, 2022
@faucomte97 faucomte97 changed the title Refine templates docs: Refine templates May 27, 2022
@faucomte97 faucomte97 enabled auto-merge (squash) May 27, 2022 14:13
Copy link
Contributor

@dionizh dionizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


.github/pull_request_template.md line 2 at r1 (raw file):

<!--- Follow the spec: https://www.conventionalcommits.org/en/v1.0.0-beta.3/#specification for the PR title and description -->
<!--- List any breaking changes here with the prefix BREAKING CHANGE: -->

Same here. Remove these 2 lines?

Copy link
Member Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @dionizh and @faucomte97)


.github/pull_request_template.md line 2 at r1 (raw file):

Previously, dionizh (Dioni Zhong) wrote…

Same here. Remove these 2 lines?

Done.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1667 (e8bcfb3) into master (3df5ef8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1667   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files         171      171           
  Lines        3505     3505           
  Branches      297      297           
=======================================
  Hits         2364     2364           
  Misses       1109     1109           
  Partials       32       32           

Copy link
Contributor

@dionizh dionizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 51ece24 into master Jun 1, 2022
@faucomte97 faucomte97 deleted the refine_templates branch August 9, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants