-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Refine templates #1667
docs: Refine templates #1667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
.github/pull_request_template.md
line 2 at r1 (raw file):
<!--- Follow the spec: https://www.conventionalcommits.org/en/v1.0.0-beta.3/#specification for the PR title and description --> <!--- List any breaking changes here with the prefix BREAKING CHANGE: -->
Same here. Remove these 2 lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @dionizh and @faucomte97)
.github/pull_request_template.md
line 2 at r1 (raw file):
Previously, dionizh (Dioni Zhong) wrote…
Same here. Remove these 2 lines?
Done.
Codecov Report
@@ Coverage Diff @@
## master #1667 +/- ##
=======================================
Coverage 67.44% 67.44%
=======================================
Files 171 171
Lines 3505 3505
Branches 297 297
=======================================
Hits 2364 2364
Misses 1109 1109
Partials 32 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
This change is