feat: add message when move towards is rejected #1669
Conversation
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @razvan-pro)
aimmo-game/tests/test_simulation/test_action.py line 59 at r1 (raw file):
assert self.avatar.events == [event.FailedMoveEvent(ORIGIN, NORTH_OF_ORIGIN)] def test_failed_move_towards_action(self):
How does this test work? o.O
I can't see how the avatar goes towards another stationary avatar.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
aimmo-game/tests/test_simulation/test_action.py line 59 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
How does this test work? o.O
I can't see how the avatar goes towards another stationary avatar.
I think it's because can_move_to returns False on any location on EmptyMap - I mostly copied from the test above 😄
The test coverage doesn't work though. I'm checking for REJECT_MESSAGE below, so it definitely goes through there - we should probably force?
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)
Codecov Report
@@ Coverage Diff @@
## master #1669 +/- ##
==========================================
- Coverage 67.54% 67.44% -0.10%
==========================================
Files 171 171
Lines 3500 3505 +5
Branches 297 297
==========================================
Hits 2364 2364
- Misses 1104 1109 +5
Partials 32 32
|
This change is