Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: badge initialisation when starting game #1670

Merged
merged 3 commits into from
Jun 6, 2022
Merged

fix: badge initialisation when starting game #1670

merged 3 commits into from
Jun 6, 2022

Conversation

dionizh
Copy link
Contributor

@dionizh dionizh commented May 31, 2022

This change is Reviewable

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dionizh)

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dionizh)

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #1670 (7127c83) into master (901f3bd) will decrease coverage by 0.65%.
The diff coverage is 58.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1670      +/-   ##
==========================================
- Coverage   67.98%   67.33%   -0.66%     
==========================================
  Files         165      171       +6     
  Lines        3377     3517     +140     
  Branches      283      298      +15     
==========================================
+ Hits         2296     2368      +72     
- Misses       1054     1117      +63     
- Partials       27       32       +5     
Impacted Files Coverage Δ
aimmo-game/simulation/action.py 0.00% <0.00%> (ø)
aimmo-game/simulation/game_state.py 72.22% <ø> (ø)
aimmo-game/simulation/simulation_runner.py 95.45% <ø> (-0.11%) ⬇️
aimmo/urls.py 100.00% <ø> (ø)
aimmo/worksheets.py 86.36% <ø> (ø)
game_frontend/src/img/1_change_direction.svg 50.00% <ø> (ø)
game_frontend/src/img/1_investigate.svg 50.00% <ø> (ø)
game_frontend/src/img/1_random_directions.svg 50.00% <ø> (ø)
game_frontend/src/pyodide/webWorker.ts 22.22% <ø> (ø)
...ontend/src/redux/features/AvatarWorker/reducers.js 8.33% <0.00%> (-4.17%) ⬇️
... and 11 more

@dionizh dionizh merged commit 0672c65 into master Jun 6, 2022
@dionizh dionizh deleted the badges_init branch June 6, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants