Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check if move action on badge 2 #1684

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix: Check if move action on badge 2 #1684

merged 1 commit into from
Jun 16, 2022

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Jun 16, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Jun 16, 2022
Copy link
Collaborator

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1684 (b59df63) into master (d5c5c85) will increase coverage by 20.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1684       +/-   ##
===========================================
+ Coverage   67.22%   87.95%   +20.72%     
===========================================
  Files         171       38      -133     
  Lines        3518     1046     -2472     
  Branches      297      159      -138     
===========================================
- Hits         2365      920     -1445     
+ Misses       1121      103     -1018     
+ Partials       32       23        -9     
Impacted Files Coverage Δ
game_frontend/src/pyodide/badges.ts
aimmo/avatar_examples/simple_avatar.py
aimmo/views.py
aimmo/migrations/0001_initial.py
aimmo/management/commands/generate_players.py
game_frontend/src/babylon/environment/terrain.ts
game_frontend/src/babylon/environment/camera.ts
aimmo-game/setup.py
...me_frontend/src/babylon/environment/environment.ts
game_frontend/src/babylon/entities/index.ts
... and 125 more

@faucomte97 faucomte97 enabled auto-merge (squash) June 16, 2022 16:40
@faucomte97 faucomte97 merged commit 31f5a8c into master Jun 16, 2022
@faucomte97 faucomte97 deleted the badge2_fix branch August 9, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants