Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove autoconfig #1697

Merged
merged 10 commits into from Sep 2, 2022
Merged

fix: Remove autoconfig #1697

merged 10 commits into from Sep 2, 2022

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Aug 31, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Aug 31, 2022
@faucomte97 faucomte97 marked this pull request as ready for review August 31, 2022 14:52
Copy link
Collaborator

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 9 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1697 (8e8fa69) into master (901f3bd) will decrease coverage by 0.59%.
The diff coverage is 73.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
- Coverage   67.98%   67.39%   -0.60%     
==========================================
  Files         165      172       +7     
  Lines        3377     3548     +171     
  Branches      283      302      +19     
==========================================
+ Hits         2296     2391      +95     
- Misses       1054     1125      +71     
- Partials       27       32       +5     
Impacted Files Coverage Δ
aimmo-game/simulation/action.py 0.00% <0.00%> (ø)
aimmo-game/simulation/game_state.py 72.22% <ø> (ø)
aimmo-game/simulation/simulation_runner.py 95.45% <ø> (-0.11%) ⬇️
aimmo/urls.py 100.00% <ø> (ø)
aimmo/worksheets.py 86.36% <ø> (ø)
game_frontend/src/babylon/assetPacks/preHistory.ts 0.00% <0.00%> (ø)
...ame_frontend/src/babylon/assetPacks/wrongFuture.ts 0.00% <0.00%> (ø)
...me_frontend/src/babylon/environment/environment.ts 0.00% <0.00%> (ø)
game_frontend/src/img/1_change_direction.svg 50.00% <ø> (ø)
game_frontend/src/img/1_investigate.svg 50.00% <ø> (ø)
... and 64 more

@faucomte97 faucomte97 merged commit 1e1c864 into master Sep 2, 2022
@faucomte97 faucomte97 deleted the remove_autoconfig branch September 2, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants