Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean autoconfig #1698

Merged
merged 4 commits into from
Sep 5, 2022
Merged

fix: Clean autoconfig #1698

merged 4 commits into from
Sep 5, 2022

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Sep 2, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Sep 2, 2022
Copy link
Collaborator

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


example_project/settings.py line 2 at r1 (raw file):

"""Django settings for example_project project."""
import os

Very important change 😂

Copy link
Collaborator

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1698 (3475518) into master (1c18fa9) will decrease coverage by 1.24%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1698      +/-   ##
==========================================
- Coverage   67.39%   66.14%   -1.25%     
==========================================
  Files         172      176       +4     
  Lines        3548     3636      +88     
  Branches      302      302              
==========================================
+ Hits         2391     2405      +14     
- Misses       1125     1199      +74     
  Partials       32       32              
Impacted Files Coverage Δ
example_project/manage.py 0.00% <0.00%> (ø)
example_project/settings.py 0.00% <0.00%> (ø)
example_project/urls.py 100.00% <ø> (ø)
example_project/wsgi.py 0.00% <0.00%> (ø)
example_project/test_settings.py 100.00% <100.00%> (ø)

@faucomte97 faucomte97 merged commit dac77fe into master Sep 5, 2022
@faucomte97 faucomte97 deleted the clean_autoconfig branch September 5, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants